fix: make CDP errors non fatal#27709
Merged
Merged
Conversation
mschile
approved these changes
Aug 30, 2023
AtofStryker
approved these changes
Aug 30, 2023
1 flaky test on run #50679 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Output
Screenshots
|
|
Review all test suite changes for PR #27709 ↗︎
tgriesser
reviewed
Aug 30, 2023
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
We want to ensure that CDP errors don't get treated as fatal with respect to protocol. Most CDP errors aren't critical and this will ensure that the databases get uploaded even when these errors happen.
How has the user experience changed?
The DB will upload even when there are CDP errors
PR Tasks
cypress-documentation?type definitions?