fix: set a crashed flag when cri detects a crash#27909
Merged
Merged
Conversation
ryanthemanuel
approved these changes
Sep 26, 2023
Collaborator
ryanthemanuel
left a comment
There was a problem hiding this comment.
Looks good. Thanks for getting this fixed!
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
24 flaky tests on run #51384 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| network stubbing > waiting and aliasing > can spy on a 304 not modified image response |
Output
|
|
e2e/origin/basic_login.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| Multi-step Auth > final-auth redirects back to localhost - flat |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Test Replay
Output
Screenshots
|
|
The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud.
Review all test suite changes for PR #27909 ↗︎
mschile
approved these changes
Sep 27, 2023
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
When a crash is encountered, CRI does not automatically reject CDP commands. This was preventing capture protocol from properly completing afterSpec cleanup. To fix this, the CRI client listens for a crash signal and sets a
crashedflag so thatsendcan properly reject its return promise.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?