misc(a11y): Update <ul> and roles to be accurate to their intended purpose in launchpad UI#28774
Merged
Conversation
36 flaky tests on run #53833 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > intercept aliases > returns null if no xhr is found |
Test Replay
|
|
| ... > intercept aliases > returns the 3rd xhr as null |
Test Replay
|
|
e2e/origin/origin.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| cy.origin > withBeforeEach > passes runnable state to the secondary origin on retry |
| |||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| cy.origin > withBeforeEach > passes runnable state to the secondary origin on retry |
Test Replay
|
|
e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > throws when foo cannot resolve |
Test Replay
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Test Replay
|
|
| ... > correctly returns currentRetry |
Test Replay
|
|
| ... > correctly returns currentRetry |
Test Replay
|
|
The first 5 flaky specs are shown, see all 20 specs in Cypress Cloud.
Review all test suite changes for PR #28774 ↗︎
AtofStryker
approved these changes
Feb 1, 2024
Comment on lines
+141
to
+143
| <li role="option"> | ||
| <slot name="footer" /> | ||
| </li> |
Member
There was a problem hiding this comment.
I know you didn't add this, but looking at the code + screenshot, this is a super bizzare usage to place an info/link item in the select 😅
emilyrohrbough
approved these changes
Feb 2, 2024
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing some a11y issues found while using Cypress Cloud Accessibility Beta mostly around this dropdown in the Launchpad
Additional details
Cypress a11y violation: I think this is reporting incorrectly, see Slack, but updating the structure of the DOM to have proper nesting of ul > li > div resolved it.
Cypress a11y violation: Every element within a listbox must have role=option. I wrapped the footer of the select in an li element with a role=option.
I updated a test to accommodate for the new update, but also rewrote it to be more descriptive when it fails and less brittle to HTML changes. It was failing with this nondescript error before.
Steps to test
Check percy snapshots to ensure they have not changed. Check Cypress a11y score to see they are lower for launchpad.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?