fix: update cypress design system buttons

[elevatebart]

closes #28852

Updates the vue button dependency to account for type property in html.
It fixes other issues with buttons being too large.

See changelog

More info:

What happens

When one clicks on the close Button, it has the wrong button type so, after closing the browser, the click re-submits the form, re-opening it.

Why does it re-submit now while before this change everything was fine? Html buttons have type="submit" by default. and version 0.11.0 of the design system does not implement the type attribute properly.

Why it happened

I made sure the bug was fixed in the design system and was implemented in full in my branch before moving the PR out of draft, but I expect that a bad merge rolled back the dependency to the button. As of now, the app and the launchpad still use 2 different version of the button. They are both outdated and with documented issues.

How to fix

Update both dependency numbers to the latest version

How to avoid it happening again

Add a component test to check that each button triggers the right event and only the right event.

[cypress]

29 flaky tests on run #53889 ↗︎

0

28975

1343

0

29

Details:

Merge branch 'develop' into 28852-close-button-not-working-on-choose-browser-pag...
Project: cypress	Commit: 66a4c0164c
Status: Passed	Duration: 21:12 💡
Started: Feb 6, 2024 3:15 PM	Ended: Feb 6, 2024 3:36 PM

  e2e/origin/origin.cy.ts • 1 flaky test • 5x-driver-firefox

View Output

Test		Artifacts
cy.origin > withBeforeEach > passes runnable state to the secondary origin on retry		</td> </tr></table>   cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox View Output Test Artifacts ... > correctly returns currentRetry </td> </tr> <tr> <td colspan="2"> <a href="https://cloud.cypress.io/projects/ypt4pf/runs/53889/overview/e3f31949-d10d-47df-971b-0e332538424d?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test"> ... > correctly returns currentRetry </a> </td> <td> </td> </tr> <tr> <td colspan="2"> <a href="https://cloud.cypress.io/projects/ypt4pf/runs/53889/overview/5e2779e8-2a83-4081-bacb-4cd754b13fe5?reviewViewBy=FLAKY&utm_source=github&utm_medium=flaky&utm_campaign=view%20test"> ... > correctly returns currentRetry </a> </td> <td> </td> </tr></table>   e2e/origin/origin.cy.ts • 1 flaky test • 5x-driver-electron View Output Test Artifacts cy.origin > withBeforeEach > passes runnable state to the secondary origin on retry Test Replay   cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron View Output Test Artifacts ... > correctly returns currentRetry Test Replay ... > correctly returns currentRetry Test Replay ... > correctly returns currentRetry Test Replay   specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e View Output Test Artifacts App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Screenshots The first 5 flaky specs are shown, see all 16 specs in Cypress Cloud. Review all test suite changes for PR #28860 ↗︎

[MikeMcC399]

I successfully tested on Ubuntu 22.04 and Windows 11 with Node.js 18.15.0 using yarn / yarn start with a default E2E project.

The Close button now closes the browser and does not reopen it. 👍🏻

[elevatebart]

@emilyrohrbough I updated the changelog AND moved it to Misc (though I fail to see the difference).

I hope the PR is now OK.

[elevatebart]

Thanks @MikeMcC399 for the pointer, I had skipped that part.

[elevatebart]

@emilyrohrbough sorry about my brain fart.
I fixed the Changelog, moved the Bufixes section above the Misc stuff, and update the PR. I hope it can be merged soonish.

[cypress-bot]

Released in 13.6.5.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.5, please open a new issue.