fix: non-JSON response body display for upload errors#29801
Merged
Conversation
cacieprins
commented
Jul 3, 2024
462b21f to
3caeda0
Compare
AtofStryker
reviewed
Jul 8, 2024
mschile
reviewed
Jul 11, 2024
Passing run #56115 ↗︎
Details:
Review all test suite changes for PR #29801 ↗︎ |
|||||||||||||||
mschile
approved these changes
Jul 11, 2024
Collaborator
mschile
left a comment
There was a problem hiding this comment.
Looks good overall! Just added one small suggestion.
AtofStryker
approved these changes
Jul 11, 2024
Co-authored-by: Matt Schile <mschile@cypress.io>
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Upload endpoints can return response bodies that are not JSON when an HTTP error occurs. This PR ensures we properly parse response bodies, display them, and include them in the error report sent to the Cloud API.
Steps to test
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?