misc: Display viewport info in badge, remove dropdown explanation of viewport dimensions#31119
Merged
Merged
Conversation
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
viewport-dimensions-ux-update
|
| Run status |
|
| Run duration | 09m 32s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
260
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
44.19%
|
|
|---|---|
|
Untested elements
|
72
|
|
Tested elements
|
57
|
Accessibility
94.9%
|
|
|---|---|
|
Failed rules
|
0 critical
6 serious
0 moderate
1 minor
|
|
Failed elements
|
132
|
AtofStryker
approved these changes
Feb 21, 2025
Collaborator
AtofStryker
left a comment
There was a problem hiding this comment.
I really like this change!
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 23, 2025
…e dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 23, 2025
…dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 23, 2025
…e dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 23, 2025
…dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 23, 2025
…e dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 23, 2025
…dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
…e dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
…dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
…e dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
…dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
…e dropdown explanation of viewport dimensions (#31119)
cypress-app-bot
pushed a commit
that referenced
this pull request
Feb 24, 2025
…dropdown explanation of viewport dimensions (#31119)
jennifer-shehane
pushed a commit
that referenced
this pull request
Feb 24, 2025
* chore: updating v8 snapshot cache * index on develop: 7012f11 misc: Display viewport info in badge, remove dropdown explanation of viewport dimensions (#31119) * index on develop: 7012f11 misc: Display viewport info in badge, remove dropdown explanation of viewport dimensions (#31119) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane
pushed a commit
that referenced
this pull request
Feb 24, 2025
* chore: updating v8 snapshot cache * index on develop: 7012f11 misc: Display viewport info in badge, remove dropdown explanation of viewport dimensions (#31119) * index on develop: 7012f11 misc: Display viewport info in badge, remove dropdown explanation of viewport dimensions (#31119) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
jennifer-shehane
pushed a commit
that referenced
this pull request
Feb 24, 2025
* chore: updating v8 snapshot cache * index on develop: 7012f11 misc: Display viewport info in badge, remove dropdown explanation of viewport dimensions (#31119) * index on develop: 7012f11 misc: Display viewport info in badge, remove dropdown explanation of viewport dimensions (#31119) --------- Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
How has the user experience changed?
Before
End-to-end tests: with viewport size and scale
Component tests: just didn't render an input element (which design and I agreed is weird)
Dropdown on click of viewport
After
End-to-end tests:
Component tests:
PR Tasks
cypress-documentation?type definitions?