Skip to content

fix: allow version 10 of the babel-loader peer dependency#31218

Merged
AtofStryker merged 14 commits into
cypress-io:developfrom
cek-roadmunk-tempo:fix/allow-babel-loader-v10-peer-dep
Mar 26, 2025
Merged

fix: allow version 10 of the babel-loader peer dependency#31218
AtofStryker merged 14 commits into
cypress-io:developfrom
cek-roadmunk-tempo:fix/allow-babel-loader-v10-peer-dep

Conversation

@cek-roadmunk-tempo
Copy link
Copy Markdown
Contributor

@cek-roadmunk-tempo cek-roadmunk-tempo commented Mar 4, 2025

Additional details

There is a dependency between babel-loader and @cypress/webpack-preprocessor. The max babel-loader version allowed is v9. This PR bumps the allowed version to v10.

Here are the breaking changes in babel-loader v10:

  • bump node requirement to ^18.20.0 || ^20.10.0 || >=22.0.0 and webpack requirement to >= 5.61.0
  • breaking: use output.hashFunction as loader cache hasher

As far as I can ascertain, this should have no negative effects on this package or cypress.

Steps to test

I used npm link to install the modified @cypress/webpack-preprocessor package into my own cypress project with babel-loader v10. I didn't encounter any issues.

How has the user experience changed?

No change.

PR Tasks

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 4, 2025

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Copy Markdown
Collaborator

@cek-roadmunk-tempo cek-roadmunk-tempo changed the title allow v10 of babel-loader fix: allow version 10 of the babel-loader peer dependency Mar 4, 2025
@cek-roadmunk-tempo cek-roadmunk-tempo changed the title fix: allow version 10 of the babel-loader peer dependency dependency: allow version 10 of the babel-loader peer dependency Mar 4, 2025
@cek-roadmunk-tempo cek-roadmunk-tempo changed the title dependency: allow version 10 of the babel-loader peer dependency fix: allow version 10 of the babel-loader peer dependency Mar 4, 2025
@cek-roadmunk-tempo
Copy link
Copy Markdown
Contributor Author

I used the v9 babel-loader dependency update as a reference.

@cek-roadmunk-tempo cek-roadmunk-tempo force-pushed the fix/allow-babel-loader-v10-peer-dep branch from ba3a5fb to 526b767 Compare March 4, 2025 23:40
@cek-roadmunk-tempo cek-roadmunk-tempo marked this pull request as ready for review March 5, 2025 00:04
Comment thread npm/webpack-preprocessor/package.json Outdated
Copy link
Copy Markdown
Collaborator

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cek-roadmunk-tempo. Thank you for opening a PR. This is currently a breaking change where this PR stands, but adding the code suggestion below would fix that. Would you also be able to update the babel-loader dependency in webpack-preprocessor if you have time just to help with test coverage?

Comment thread npm/webpack-preprocessor/package.json Outdated
Co-authored-by: Bill Glesias <bglesias@gmail.com>
@cek-roadmunk-tempo
Copy link
Copy Markdown
Contributor Author

cek-roadmunk-tempo commented Mar 14, 2025

Would you also be able to update the babel-loader dependency in webpack-preprocessor if you have time just to help with test coverage?

I'll work on this next.

@AtofStryker AtofStryker self-requested a review March 14, 2025 19:35
@cek-roadmunk-tempo
Copy link
Copy Markdown
Contributor Author

Concerning the failed check, is there anything I should do?

@AtofStryker
Copy link
Copy Markdown
Collaborator

Concerning the failed check, is there anything I should do?

@cek-roadmunk-tempo I don't think so. It looks like build flake which sometimes happens with contributor PRs. If it continues to be a problem, I will investigate

@AtofStryker
Copy link
Copy Markdown
Collaborator

If this is still a problem I will revert the bump in the loader itself (not the peer dep change)

@AtofStryker
Copy link
Copy Markdown
Collaborator

@cek-roadmunk-tempo I made a few changes to the PR which look to have resolved the failures. Only downside is now that I am touching the packages directory, I need to add a changelog entry. I have taken care of this and should be merging this in today

@cek-roadmunk-tempo
Copy link
Copy Markdown
Contributor Author

a few changes to the PR which look to have resolved the failures. Only downside is now that I am touching the packages directory, I need to add a changelog entry. I have taken care of this and should be merging this in today

Many thanks for shepherding this through and resolving the failures.

@AtofStryker AtofStryker merged commit 33cf18e into cypress-io:develop Mar 26, 2025
@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Apr 8, 2025

Released in 14.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.3.0, please open a new issue.

@cypress-bot cypress-bot Bot locked as resolved and limited conversation to collaborators Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants