fix: allow version 10 of the babel-loader peer dependency#31218
Conversation
|
|
I used the v9 babel-loader dependency update as a reference. |
ba3a5fb to
526b767
Compare
AtofStryker
left a comment
There was a problem hiding this comment.
Hi @cek-roadmunk-tempo. Thank you for opening a PR. This is currently a breaking change where this PR stands, but adding the code suggestion below would fix that. Would you also be able to update the babel-loader dependency in webpack-preprocessor if you have time just to help with test coverage?
Co-authored-by: Bill Glesias <bglesias@gmail.com>
I'll work on this next. |
|
Concerning the failed check, is there anything I should do? |
@cek-roadmunk-tempo I don't think so. It looks like build flake which sometimes happens with contributor PRs. If it continues to be a problem, I will investigate |
|
If this is still a problem I will revert the bump in the loader itself (not the peer dep change) |
…w-babel-loader-v10-peer-dep
|
@cek-roadmunk-tempo I made a few changes to the PR which look to have resolved the failures. Only downside is now that I am touching the |
Many thanks for shepherding this through and resolving the failures. |
…roadmunk-tempo/cypress into fix/allow-babel-loader-v10-peer-dep
…w-babel-loader-v10-peer-dep
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
There is a dependency between babel-loader and @cypress/webpack-preprocessor. The max babel-loader version allowed is v9. This PR bumps the allowed version to v10.
Here are the breaking changes in babel-loader v10:
^18.20.0 || ^20.10.0 || >=22.0.0and webpack requirement to>= 5.61.0output.hashFunctionas loader cache hasherAs far as I can ascertain, this should have no negative effects on this package or cypress.
Steps to test
I used
npm linkto install the modified@cypress/webpack-preprocessorpackage into my own cypress project with babel-loader v10. I didn't encounter any issues.How has the user experience changed?
No change.
PR Tasks
cypress-documentation?type definitions?