fix: no longer hang when piping stdout+stderr to a file under certain conditions#31631
Merged
Conversation
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
dep/revert-cli-table3
|
| Run status |
|
| Run duration | 08m 37s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
19
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
20%
|
|
|---|---|
|
Untested elements
|
4
|
|
Tested elements
|
1
|
Accessibility
89.8%
|
|
|---|---|
|
Failed rules
|
0 critical
2 serious
0 moderate
0 minor
|
|
Failed elements
|
11
|
jennifer-shehane
approved these changes
May 5, 2025
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
When using
@cypress/grepresults in running many spec files, piping stdout and stderr to a file can cause Cypress to hang. Downgradingcli-table3to 0.6.1 resolves the issue.Steps to test
With https://github.com/eswanny22/cypress-cli-table3-issue, run the test suite with similar args to:
npx cypress run --env grepTags=@issue,grepFilterSpecs=true > testResults.log 2>&1. Cypress should not hang before running any tests.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?