dependency: upgrade tar-fs to 2.1.3 and 3.1.0#32160
Merged
Merged
Conversation
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ryanm/chore/tar-fs
|
| Run status |
|
| Run duration | 20m 19s |
| Commit |
|
| Committer | Ryan Manuel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
14
|
Pending
|
1230
|
Skipped
|
0
|
Passing
|
32178
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.83%
|
|
|---|---|
|
Untested elements
|
190
|
|
Tested elements
|
165
|
Accessibility
97.95%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
107
|
Tests for review
cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > does not remove the studio url parameters if saving fails |
Test Replay
Screenshots
|
|
e2e/e2e_cookies.cy.js • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| e2e cookies spec > __Host- prefix > can set __Host- cookie |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 1st response to bar |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
e2e/e2e_cookies.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| e2e cookies spec > __Host- prefix > can set __Host- cookie |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud.
jennifer-shehane
approved these changes
Aug 5, 2025
AtofStryker
approved these changes
Aug 5, 2025
MikeMcC399
reviewed
Aug 6, 2025
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Upgrade
tar-fsto 2.1.3 and 3.1.0 in places we can control, to resolve CVE-2024-12905.@puppeteer/browsersstill references 3.0.4, but it is only used to download browsers which is not a feature ofpuppeteerthat we utilize.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?