misc: Improved the hitbox of grouped commands caret#32783
Merged
Conversation
mschile
requested changes
Oct 21, 2025
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
fix-command-group-expand-hitbox
|
| Run status |
|
| Run duration | 22m 04s |
| Commit |
|
| Committer | Jennifer Shehane |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
11
|
Pending
|
1102
|
Skipped
|
4
|
Passing
|
26752
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.89%
|
|
|---|---|
|
Untested elements
|
186
|
|
Tested elements
|
162
|
Accessibility
97.98%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
mschile
approved these changes
Oct 22, 2025
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Expands the hitbox of the collapse of grouped commands.
Before
After
Screen.Recording.2025-10-21.at.2.36.52.PM.mov
I added a snapshot for nested grouped commands to Percy also:
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Widens the grouped command caret hitbox in the reporter, adds grouped-commands snapshot test, disables spinner animation in snapshots, and updates the changelog.
commands.scss(.command-expander-column-groupwidth/padding/margins; shift.command-wrapper-text-grouptomargin-left).packages/app/cypress/e2e/runner/support/snapshot-reporter.ts, stop active test title spinner animation via'.runnable-active .runnable-state-icon animate'override.ui-states.cy.tsand fixture specsystem-tests/.../commands.cy.js; capture Percy snapshot viasnapshotReporter().cli/CHANGELOG.md.Written by Cursor Bugbot for commit 516f5de. This will update automatically on new commits. Configure here.