try 2: fix type when previous selection in input in some cases

[kuceb]

• retry of reverted PR fix type when previous selection in input in some cases #5809 with bugfix for regression caught in develop + more tests

• Closes 3.5.0-3.6.1 regression - cy.type() may skip a character on a autofocussing textbox #5703

User facing changelog

• fixes issue with .type not respecting previous selection in non-selectionRange input element (email, number) (only way to change selection is with .select())
• fixes issue with .type not respecting previous selection if current value of the input is same as key

Additional details

• code from firefox branch was pulled in, causing the large amount of files changed. This will help reduce changes needed for firefox as well

How has the user experience changed?

when attempting to use .type on a number or email input that has a text selection (or is selected in a focus handler):

before (incorrect): text is appended to the current selection
after (correct): text replaces current selection

when attempting to use .type on an input that has a text selection (or is selected in a focus handler) of 1 character equal to the key typed:

before (incorrect): ignores current key, next character replaces selection
after (correct): text replaces current selection, next character is typed after

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

3533 • 0 • 45 • 0

---

Run details

Project	cypress
Status	Passed
Commit	c474554
Started	Dec 3, 2019 12:36 AM
Ended	Dec 3, 2019 12:40 AM
Duration	04:07 💡
OS	Linux Debian - 9.8
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard