Skip to content

Upgrade browserify preprocessor to 2.1.4#6419

Merged
jennifer-shehane merged 2 commits into
developfrom
issue-6403-fix-require
Feb 12, 2020
Merged

Upgrade browserify preprocessor to 2.1.4#6419
jennifer-shehane merged 2 commits into
developfrom
issue-6403-fix-require

Conversation

@chrisbreiding
Copy link
Copy Markdown
Contributor

User facing changelog

Update @cypress/browserify-preprocessor to 2.1.4, fixing a regression involving non-top-level requires in tests.

Additional details

How has the user experience changed?

PR Tasks

  • N/A Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Feb 11, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@chrisbreiding chrisbreiding changed the title bump browserify preprocessor to 2.1.4 Upgrade browserify preprocessor to 2.1.4 Feb 11, 2020
@cypress
Copy link
Copy Markdown

cypress Bot commented Feb 11, 2020



Test summary

6863 0 97 0


Run details

Project cypress
Status Passed
Commit c374497
Started Feb 11, 2020 5:17 PM
Ended Feb 11, 2020 5:22 PM
Duration 05:35 💡
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Copy Markdown
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually ran the previous failing test - is working with this change. 👍

@jennifer-shehane jennifer-shehane merged commit 49fb621 into develop Feb 12, 2020
@chrisbreiding chrisbreiding deleted the issue-6403-fix-require branch April 5, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

require() not working after upgrade

2 participants