Skip to content

fix: typedefs for isBrowser#6448

Merged
kuceb merged 3 commits into
developfrom
fix-typedefs-isbrowser
Feb 13, 2020
Merged

fix: typedefs for isBrowser#6448
kuceb merged 3 commits into
developfrom
fix-typedefs-isbrowser

Conversation

@kuceb
Copy link
Copy Markdown
Contributor

@kuceb kuceb commented Feb 13, 2020

User facing changelog

Fix incorrect type definition for Cypress.isBrowser() api

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Feb 13, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

Comment thread cli/types/tests/cypress-tests.ts
@cypress
Copy link
Copy Markdown

cypress Bot commented Feb 13, 2020



Test summary

6863 0 97 0


Run details

Project cypress
Status Passed
Commit 387ec13
Started Feb 13, 2020 5:58 PM
Ended Feb 13, 2020 6:04 PM
Duration 05:40 💡
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Comment thread cli/types/index.d.ts Outdated
Comment thread cli/types/index.d.ts Outdated
@kuceb kuceb requested review from bahmutov and flotwig February 13, 2020 17:27
bahmutov
bahmutov previously approved these changes Feb 13, 2020
@kuceb kuceb merged commit 1479804 into develop Feb 13, 2020
@emilyrohrbough emilyrohrbough deleted the fix-typedefs-isbrowser branch August 1, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incorrect type definition for isBrowser

3 participants