Skip to content

Downgrade execa to 1.0.0 (to actually support Node 8.0.0)#6560

Merged
jennifer-shehane merged 1 commit into
developfrom
roll-back-to-execa-1
Feb 26, 2020
Merged

Downgrade execa to 1.0.0 (to actually support Node 8.0.0)#6560
jennifer-shehane merged 1 commit into
developfrom
roll-back-to-execa-1

Conversation

@jennifer-shehane
Copy link
Copy Markdown
Member

@jennifer-shehane jennifer-shehane commented Feb 26, 2020

User facing changelog

  • We fixed an issue where Cypress would not install using Node.js 8 due to a dependency's code not being compatible with Node.js version lower than 8.12.0.
  • Downgraded execa from 3.0.0 to 1.0.0.

Additional details

How has the user experience changed?

Should no longer see the errors below during install:

yarn

error execa@3.3.0: The engine "node" is incompatible with this module. Expected version "^8.12.0 || >=9.7.0". Got "8.0.0"
error Found incompatible module.

npm install

> cypress@4.0.2 postinstall /Users/jennifer/Dev/cypress-transform-test/node_modules/cypress
> node index.js --exec install

/Users/jennifer/Dev/cypress-transform-test/node_modules/execa/index.js:18
	const env = extendEnv ? {...process.env, ...envOption} : envOption;
	                         ^^^

SyntaxError: Unexpected token ...
    at createScript (vm.js:74:10)
    at Object.runInThisContext (vm.js:116:10)
    at Module._compile (module.js:533:28)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/jennifer/Dev/cypress-transform-test/node_modules/cypress/lib/util.js:18:13)

@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Feb 26, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@jennifer-shehane jennifer-shehane changed the title Roll back execa to 1.0.0 to actually support Node 8.0.0 Downgrade execa to 1.0.0 (to actually support Node 8.0.0) Feb 26, 2020
@cypress

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when installing cypress using Node.js version < 8.12.0

2 participants