Skip to content

add Cypress.sinon type#6725

Merged
flotwig merged 1 commit into
developfrom
add-sinon-type
Mar 16, 2020
Merged

add Cypress.sinon type#6725
flotwig merged 1 commit into
developfrom
add-sinon-type

Conversation

@bahmutov
Copy link
Copy Markdown
Contributor

User facing changelog

Added TypeScript for property Cypress.sinon

Additional details

This property exists on the object, but we did not have the type for it

How has the user experience changed?

Errors are gone, see the issue for screenshots

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • Have API changes been updated in the type definitions?

Related docs PR: cypress-io/cypress-documentation#2608

@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Mar 13, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@bahmutov bahmutov requested a review from CypressJoseph March 13, 2020 19:36
@cypress
Copy link
Copy Markdown

cypress Bot commented Mar 13, 2020



Test summary

6966 0 97 0


Run details

Project cypress
Status Passed
Commit 25b2742
Started Mar 13, 2020 7:40 PM
Ended Mar 13, 2020 7:46 PM
Duration 05:56 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig merged commit 333ab85 into develop Mar 16, 2020
@emilyrohrbough emilyrohrbough deleted the add-sinon-type branch August 1, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Sinon to Cypress TypeScript interface

2 participants