Skip to content

feat: Redesign Desktop GUI updates modal#8751

Merged
chrisbreiding merged 15 commits into
developfrom
tr-356-updates-modal-redesign
Oct 6, 2020
Merged

feat: Redesign Desktop GUI updates modal#8751
chrisbreiding merged 15 commits into
developfrom
tr-356-updates-modal-redesign

Conversation

@chrisbreiding
Copy link
Copy Markdown
Contributor

@chrisbreiding chrisbreiding commented Oct 5, 2020

User facing changelog

  • Feature: Updated the design of the modal shown when there is a new version of Cypress available. Added 'copy to clipboard' buttons for upgrade commands.

How has the user experience changed?

Before (project mode)

Screen Shot 2020-10-05 at 10 01 20 AM

Before (global mode)

Screen Shot 2020-10-05 at 10 01 05 AM

After (project mode)

Screen Shot 2020-10-05 at 9 58 14 AM

After (global mode)

Screen Shot 2020-10-05 at 9 58 02 AM

PR Tasks

  • Have tests been added/updated?
  • N/A Has the original issue been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Oct 5, 2020

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding changed the title Redesign Desktop GUI updates modal feature: Redesign Desktop GUI updates modal Oct 5, 2020
@cypress
Copy link
Copy Markdown

cypress Bot commented Oct 5, 2020



Test summary

8597 0 124 3


Run details

Project cypress
Status Passed
Commit 304b6c2
Started Oct 6, 2020 1:44 PM
Ended Oct 6, 2020 1:55 PM
Duration 10:49 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane changed the title feature: Redesign Desktop GUI updates modal feat: Redesign Desktop GUI updates modal Oct 6, 2020
Copy link
Copy Markdown
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Matches design, functionally works and has tests.

@jennifer-shehane jennifer-shehane changed the base branch from tr-352-footer-update to develop October 6, 2020 07:35
@jennifer-shehane jennifer-shehane dismissed their stale review October 6, 2020 07:35

The base branch was changed.

@jennifer-shehane
Copy link
Copy Markdown
Member

Ugh, merged in the other branch without realizing this was branched off it.

@chrisbreiding chrisbreiding merged commit ae5cd84 into develop Oct 6, 2020
@cypress-bot
Copy link
Copy Markdown
Contributor

cypress-bot Bot commented Oct 14, 2020

Released in 5.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.4.0, please open a new issue.

@cypress-bot cypress-bot Bot locked as resolved and limited conversation to collaborators Oct 14, 2020
@chrisbreiding chrisbreiding deleted the tr-356-updates-modal-redesign branch April 5, 2022 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants