fix: find waiting for cy.intercept when it has been overwritten by the user

[bahmutov]

• Closes Alias for intercept is not working if overwriting cy.intercept command #9580

User facing changelog

If the user overwrites cy.intercept, it still works with cy.wait(alias)

This used to show an error on cy.wait, and now it works

Cypress.Commands.overwrite('intercept', function (originalIntercept, ...args) {
  return cy.log('intercept!').then(() => {
    return originalIntercept(...args)
  })
})

cy.intercept('/foo', 'my value').as('netAlias')
cy.wait('@netAlias')

PR Tasks

• Have tests been added/updated?
• Has the original issue or this PR been tagged with a release in ZenHub?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[bahmutov]

Notes: I built this PR on top of #9589 but probably will have clean merge

Also this PR will need reconcile with #9594

[cypress]

---

Test summary

9150 • 0 • 118 • 3 • 1

---

Run details

Project	cypress
Status	Passed
Commit	454e420
Started	Dec 11, 2020 3:53 PM
Ended	Dec 11, 2020 4:05 PM
Duration	12:28 💡
OS	Linux Debian - 10.5
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/integration/retries.ui.spec.js		1
1	runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[flotwig]

this doesn't cover dynamic aliases with req.alias i don't think

but luckily you can use getAliasedRequests: https://github.com/cypress-io/cypress/blob/c6f03e390f2b3c55f9c3b9a08611c6aabad2d607/packages/driver/src/cy/net-stubbing/aliasing.ts#L14-L28

[bahmutov]

Seems to work as is, I have added a test to confirm it

[flotwig]

nice

[flotwig]

Does not fix #3890, but as #3890 is getting deprecated anyways, I'll allow it, LGTM

The base branch was changed.