Skip to content

[no-release-notes] Add tests for invalid UTF-8 import#10926

Merged
elianddb merged 1 commit into
mainfrom
elian/10924
Apr 29, 2026
Merged

[no-release-notes] Add tests for invalid UTF-8 import#10926
elianddb merged 1 commit into
mainfrom
elian/10924

Conversation

@elianddb
Copy link
Copy Markdown
Contributor

@elianddb elianddb commented Apr 22, 2026

@elianddb elianddb changed the title Elian/10924 Skip rows with invalid utf-8 on dolt table import --continue Apr 22, 2026
@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Apr 22, 2026

@elianddb DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.54 0.55 1.85
groupby_scan 9.91 10.09 1.82
index_join 1.89 1.89 0.0
index_join_scan 1.34 1.34 0.0
index_scan 21.89 21.5 -1.78
oltp_point_select 0.26 0.26 0.0
oltp_read_only 5.18 5.09 -1.74
select_random_points 0.51 0.52 1.96
select_random_ranges 0.57 0.57 0.0
table_scan 21.89 21.5 -1.78
types_table_scan 65.65 66.84 1.81
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.43 1.74
oltp_insert 3.07 3.13 1.95
oltp_read_write 11.24 11.24 0.0
oltp_update_index 3.25 3.19 -1.85
oltp_update_non_index 3.07 3.07 0.0
oltp_write_only 5.99 5.99 0.0
types_delete_insert 6.91 6.91 0.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented Apr 22, 2026

@elianddb DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 53.85 54.83 1.82
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt cb1a6d3 45.25 dolt 13f2a05 44.14 -2.45

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
2dc11d3 ok 5937471
version total_tests
2dc11d3 5937471
correctness_percentage
100.0

@elianddb elianddb changed the title Skip rows with invalid utf-8 on dolt table import --continue Skip rows with invalid string values when using --continue Apr 23, 2026
@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
13d1375 ok 5937471
version total_tests
13d1375 5937471
correctness_percentage
100.0

@elianddb elianddb changed the title Skip rows with invalid string values when using --continue Skip rows with invalid string values when using --continue Apr 23, 2026
@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
b730355 ok 5937471
version total_tests
b730355 5937471
correctness_percentage
100.0

@elianddb elianddb force-pushed the elian/10924 branch 2 times, most recently from c1ffa9d to 34b11d0 Compare April 24, 2026 21:29
@elianddb elianddb changed the title Skip rows with invalid string values when using --continue [no-release-notes] Add tests for invalid UTF-8 import Apr 24, 2026
@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
fec8301 ok 5937471
version total_tests
fec8301 5937471
correctness_percentage
100.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

@elianddb DOLT

comparing_percentages
100.000000 to 100.000000
version result total
13f2a05 ok 5937471
version total_tests
13f2a05 5937471
correctness_percentage
100.0

@elianddb elianddb merged commit 003f70e into main Apr 29, 2026
31 checks passed
@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name add_cnt delete_cnt update_cnt latency
adds_only 60000 0 0 0.61
adds_updates_deletes 60000 60000 60000 3.12
deletes_only 0 60000 0 1.49
updates_only 0 0 60000 1.9

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

test_name detail row_cnt sorted mysql_time sql_mult cli_mult
batching LOAD DATA 10000 1 0.05 1.8
batching batch sql 10000 1 0.08 1.5
batching by line sql 10000 1 0.09 1.33
blob 1 blob 200000 1 0.92 4.07 3.86
blob 2 blobs 200000 1 0.92 4.42 4.27
blob no blob 200000 1 0.9 2.74 2.46
col type datetime 200000 1 0.85 2.6 2.29
col type varchar 200000 1 0.67 3.91 3.45
config width 2 cols 200000 1 0.78 2.68 2.38
config width 32 cols 200000 1 1.91 3.08 3.72
config width 8 cols 200000 1 0.98 2.81 2.56
pk type float 200000 1 0.87 2.46 2.2
pk type int 200000 1 0.79 2.65 2.35
pk type varchar 200000 1 1.46 1.82 1.59
row count 1.6mm 1600000 1 5.81 2.94 2.57
row count 400k 400000 1 1.44 2.91 2.58
row count 800k 800000 1 2.85 2.97 2.61
secondary index four index 200000 1 3.66 1.33 1.08
secondary index no secondary 200000 1 0.9 2.73 2.47
secondary index one index 200000 1 1.21 2.42 2.06
secondary index two index 200000 1 2.07 1.7 1.42
sorting shuffled 1mm 1000000 0 4.94 2.82 2.53
sorting sorted 1mm 1000000 1 5.15 2.69 2.39

@github-actions
Copy link
Copy Markdown

@coffeegoddd DOLT

name detail mean_mult
dolt_blame_basic system table 1.19
dolt_blame_commit_filter system table 1.15
dolt_commit_ancestors_commit_filter system table 0.62
dolt_commits_commit_filter system table 1.06
dolt_diff_log_join_from_commit system table 2.59
dolt_diff_log_join_to_commit system table 2.6
dolt_diff_table_from_commit_filter system table 1.31
dolt_diff_table_to_commit_filter system table 1.35
dolt_diffs_commit_filter system table 1.1
dolt_history_commit_filter system table 1.52
dolt_log_commit_filter system table 1.17

@tbantle22 tbantle22 deleted the elian/10924 branch May 20, 2026 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dolt table import should error when importing invalid charset

2 participants