replace all decimal.Decimal with *apd.Decimal

[jennifersp]

Depends on dolthub/go-mysql-server#3532

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 99.999882

version	result	total
6f91e88	not ok	7
6f91e88	ok	5937464

version	total_tests
6f91e88	5937471

correctness_percentage
99.999882

[coffeegoddd]

@jennifersp DOLT

read_tests	from_latency	to_latency	percent_change
covering_index_scan	0.54	0.55	1.85
groupby_scan	9.73	9.91	1.85
index_join	1.86	1.86	0.0
index_join_scan	1.34	1.32	-1.49
index_scan	22.28	20.74	-6.91
oltp_point_select	0.25	0.25	0.0
oltp_read_only	5.09	5.09	0.0
select_random_points	0.51	0.51	0.0
select_random_ranges	0.56	0.56	0.0
table_scan	22.28	20.37	-8.57
types_table_scan	47.47	45.79	-3.54

write_tests	from_latency	to_latency	percent_change
oltp_delete_insert	6.21	6.21	0.0
oltp_insert	3.02	3.02	0.0
oltp_read_write	10.84	10.84	0.0
oltp_update_index	3.13	3.13	0.0
oltp_update_non_index	2.97	2.97	0.0
oltp_write_only	5.77	5.77	0.0
types_delete_insert	6.55	6.55	0.0

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 99.999882

version	result	total
bd62077	not ok	7
bd62077	ok	5937464

version	total_tests
bd62077	5937471

correctness_percentage
99.999882

[coffeegoddd]

@jennifersp DOLT

test_name	from_latency_p95	to_latency_p95	percent_change
tpcc-scale-factor-1	44.98	46.63	3.67

test_name	from_server_name	from_server_version	from_tps	to_server_name	to_server_version	to_tps	percent_change
tpcc-scale-factor-1	dolt	0802e44	52.3	dolt	5fb80c0	50.28	-3.86

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 99.999832

version	result	total
b3147e0	not ok	10
b3147e0	ok	5937461

version	total_tests
b3147e0	5937471

correctness_percentage
99.999832

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 99.999832

version	result	total
5c3c27b	not ok	10
5c3c27b	ok	5937461

version	total_tests
5c3c27b	5937471

correctness_percentage
99.999832

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
a213c16	ok	5937471

version	total_tests
a213c16	5937471

correctness_percentage
100.0

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
63ad07a	ok	5937471

version	total_tests
63ad07a	5937471

correctness_percentage
100.0

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
c334899	ok	5937471

version	total_tests
c334899	5937471

correctness_percentage
100.0

[zachmu]

LGTM

My main issue overall is why we're using apd.Decimal instead of *apd.Decimal. A quick glance at the docs shows me that functions in that package return a pointer and most params are pointers.

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
e1848e2	ok	5937471

version	total_tests
e1848e2	5937471

correctness_percentage
100.0

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
baeef95	ok	5937471

version	total_tests
baeef95	5937471

correctness_percentage
100.0

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
c59eb84	ok	5937471

version	total_tests
c59eb84	5937471

correctness_percentage
100.0

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
d775df4	ok	5937471

version	total_tests
d775df4	5937471

correctness_percentage
100.0

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
add2b8c	ok	5937471

version	total_tests
add2b8c	5937471

correctness_percentage
100.0

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
7a29dfe	ok	5937471

version	total_tests
7a29dfe	5937471

correctness_percentage
100.0

[coffeegoddd]

@jennifersp DOLT

comparing_percentages
100.000000 to 100.000000

version	result	total
5fb80c0	ok	5937471

version	total_tests
5fb80c0	5937471

correctness_percentage
100.0

[github-actions]

@coffeegoddd DOLT

name	add_cnt	delete_cnt	update_cnt	latency
adds_only	60000	0	0	0.6
adds_updates_deletes	60000	60000	60000	2.93
deletes_only	0	60000	0	1.42
updates_only	0	0	60000	1.83

[github-actions]

@coffeegoddd DOLT

test_name	detail	row_cnt	sorted	mysql_time	sql_mult	cli_mult
batching	LOAD DATA	10000	1	0.05	1.8
batching	batch sql	10000	1	0.07	1.86
batching	by line sql	10000	1	0.07	1.71
blob	1 blob	200000	1	0.83	2.84	2.78
blob	2 blobs	200000	1	0.83	2.83	2.8
blob	no blob	200000	1	0.83	2.86	2.78
col type	datetime	200000	1	0.74	2.84	2.72
col type	varchar	200000	1	0.63	4.06	3.76
config width	2 cols	200000	1	0.7	3.2	2.67
config width	32 cols	200000	1	1.72	3.26	2.93
config width	8 cols	200000	1	0.87	3.02	2.9
pk type	float	200000	1	0.77	2.69	2.47
pk type	int	200000	1	0.74	2.7	2.54
pk type	varchar	200000	1	1.35	1.86	1.69
row count	1.6mm	1600000	1	5.29	3.14	2.84
row count	400k	400000	1	1.33	3.08	2.83
row count	800k	800000	1	2.65	3.13	2.82
secondary index	four index	200000	1	3.43	1.29	1.07
secondary index	no secondary	200000	1	0.84	2.82	2.74
secondary index	one index	200000	1	1.07	2.64	2.3
secondary index	two index	200000	1	1.89	1.78	1.61
sorting	shuffled 1mm	1000000	0	5.03	2.93	2.67
sorting	sorted 1mm	1000000	1	5.15	2.81	2.55

[github-actions]

@coffeegoddd DOLT

name	detail	mean_mult
dolt_blame_basic	system table	1.21
dolt_blame_commit_filter	system table	1.15
dolt_commit_ancestors_commit_filter	system table	0.61
dolt_commits_commit_filter	system table	1.11
dolt_diff_log_join_from_commit	system table	2.68
dolt_diff_log_join_to_commit	system table	2.73
dolt_diff_table_from_commit_filter	system table	1.27
dolt_diff_table_to_commit_filter	system table	1.31
dolt_diffs_commit_filter	system table	1.1
dolt_history_commit_filter	system table	1.58
dolt_log_commit_filter	system table	1.38

[ogbonnawisdom253-a11y]

Yes

[ogbonnawisdom253-a11y]

Yes is me wisdom account please