Skip to content

cleaned up binlog serialization logic#10996

Merged
zachmu merged 5 commits into
mainfrom
zachmu/binlog-fix
May 5, 2026
Merged

cleaned up binlog serialization logic#10996
zachmu merged 5 commits into
mainfrom
zachmu/binlog-fix

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented May 4, 2026

No description provided.

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented May 4, 2026

@coffeegoddd DOLT

read_tests from_latency to_latency percent_change
covering_index_scan 0.54 0.54 0.0
groupby_scan 9.73 9.73 0.0
index_join 1.86 1.86 0.0
index_join_scan 1.32 1.32 0.0
index_scan 22.28 21.89 -1.75
oltp_point_select 0.25 0.25 0.0
oltp_read_only 5.09 5.0 -1.77
select_random_points 0.51 0.51 0.0
select_random_ranges 0.56 0.57 1.79
table_scan 22.28 21.89 -1.75
types_table_scan 68.05 68.05 0.0
write_tests from_latency to_latency percent_change
oltp_delete_insert 6.32 6.43 1.74
oltp_insert 3.07 3.07 0.0
oltp_read_write 11.04 11.04 0.0
oltp_update_index 3.19 3.19 0.0
oltp_update_non_index 3.02 3.02 0.0
oltp_write_only 5.99 5.99 0.0
types_delete_insert 6.91 6.91 0.0

@coffeegoddd
Copy link
Copy Markdown
Contributor

coffeegoddd commented May 5, 2026

@coffeegoddd DOLT

test_name from_latency_p95 to_latency_p95 percent_change
tpcc-scale-factor-1 53.85 53.85 0.0
test_name from_server_name from_server_version from_tps to_server_name to_server_version to_tps percent_change
tpcc-scale-factor-1 dolt dea2ba9 45.38 dolt c1d9897 44.94 -0.97

@coffeegoddd
Copy link
Copy Markdown
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
22d8c14 ok 5937471
version total_tests
22d8c14 5937471
correctness_percentage
100.0

@zachmu zachmu merged commit e62f0dc into main May 5, 2026
35 of 38 checks passed
@coffeegoddd
Copy link
Copy Markdown
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c1d9897 ok 5937471
version total_tests
c1d9897 5937471
correctness_percentage
100.0

@tbantle22 tbantle22 deleted the zachmu/binlog-fix branch May 20, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants