Skip to content

system generate ecs.yml #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 26, 2021
Merged

system generate ecs.yml #1508

merged 3 commits into from
Aug 26, 2021

Conversation

leehinman
Copy link
Contributor

What does this PR do?

  • switches to generated ecs.yml field definitions

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package's manifest.yml file to point to the latest Elastic stack release (e.g. ^7.13.0).

Related issues

@elasticmachine
Copy link

elasticmachine commented Aug 10, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-20T17:30:45.493+0000

  • Duration: 15 min 57 sec

  • Commit: 88a4c84

Test stats 🧪

Test Results
Failed 0
Passed 266
Skipped 0
Total 266

Trends 🧪

Image of Build Times

Image of Tests

@leehinman leehinman marked this pull request as ready for review August 10, 2021 16:33
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh reviewed Aug 10, 2021
View reviewed changes
packages/system/data_stream/syslog/fields/fields.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find where version is created in the pipeline. Is it used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double checked and I can't find it being used anywhere either. removed.

@leehinman leehinman force-pushed the ecs_generate_system branch from 0355b96 to 6f24656 Compare August 18, 2021 03:23
@leehinman leehinman force-pushed the ecs_generate_system branch from 8a9b41b to 88a4c84 Compare August 20, 2021 17:30
@leehinman leehinman merged commit b619320 into elastic:master Aug 26, 2021
@leehinman leehinman deleted the ecs_generate_system branch August 26, 2021 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leehinman @elasticmachine @andrewkroh