Skip to content

Conversation

agithomas
Copy link
Contributor

  • Enhancement

Proposed commit message

Add system tests for the datasets

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Package upgrade tests

How to test this PR locally

  • elastic-package build && elastic-package stack up -v -d --services package-registry

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@agithomas agithomas marked this pull request as ready for review September 11, 2025 05:16
@agithomas agithomas requested a review from a team as a code owner September 11, 2025 05:16
@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Sep 11, 2025
@muthu-mps
Copy link
Contributor

@agithomas - Can you confirm we are able to generate sample-events by running the system tests? If possible, we could even overwrite the files which is already generated. WDYT?

@agithomas
Copy link
Contributor Author

@agithomas - Can you confirm we are able to generate sample-events by running the system tests? If possible, we could even overwrite the files which is already generated. WDYT?

All the existing sample events present under the datasets were automatically generated. It is just that i have created a separate PR for adding the configs present in this PR.

@agithomas agithomas merged commit bc0338f into elastic:main Sep 12, 2025
9 checks passed
@elastic-vault-github-plugin-prod

Package kafka - 1.22.0 containing this change is available at https://epr.elastic.co/package/kafka/1.22.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:kafka Kafka Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants