Skip to content

Conversation

MichaelKatsoulis
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis commented Jan 5, 2022

What does this PR do?

This PR adds memory.working_set.limit.pct field in kubernetes pod data stream and memory.workingset.limit.pct in kubernetes container data stream following the addition of those fields in the k8s module metrcisets by #29547

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Bring up elastic stack version 8.1.0-SNAPSHOT and enable kubernetes integration.
The new fields with the correct types are added in the metrics-kubernetes.pod and metrics-kubernetes.container index templates.

Related issues

Screenshots

pod mapping

container_mapping

@MichaelKatsoulis MichaelKatsoulis added enhancement New feature or request Team:Integrations Label for the Integrations team labels Jan 5, 2022
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

elasticmachine commented Jan 5, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-10T08:58:04.088+0000

  • Duration: 30 min 58 sec

  • Commit: 2c918e3

Test stats 🧪

Test Results
Failed 0
Passed 116
Skipped 0
Total 116

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Working set memory usage
- name: limit.pct
type: scaled_float
format: percent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Added in f0e4319

Copy link
Contributor

@tetianakravchenko tetianakravchenko Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelKatsoulis should also sample_event.json files get updated to include new fields?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes It should! 2c918e3

Total working set memory
- name: limit.pct
type: scaled_float
format: percent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same here

@MichaelKatsoulis MichaelKatsoulis merged commit 47d7bbd into elastic:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add memory.workingset.limit.pct and memory.working_set.limit.pct` fields in pod and container kubernetes integration

3 participants