Skip to content

[O11y][Oracle] Migrate Performance dashboard visualizations to lens in kibana 8.6.0 #5758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 13, 2023
Merged

[O11y][Oracle] Migrate Performance dashboard visualizations to lens in kibana 8.6.0 #5758

merged 3 commits into from
Apr 13, 2023

Conversation

harnish-crest-data
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Oracle integration package

  • Statistics for Oracle Lens migration:

Oracle Dashboards Before Migration   After Migration
  Lens Visualization Lens Visualization
[Metrics Oracle] Performance 0 15 15 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in Kibana version 8.6.0.

Related issues

Note: - Previously the screenshot was not fully updated. Hence providing screenshot for compare and review process.

image

@harnish-crest-data harnish-crest-data marked this pull request as ready for review March 30, 2023 16:52
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner March 30, 2023 16:52
@harnish-crest-data harnish-crest-data mentioned this pull request Mar 30, 2023
Closed
10 tasks
@harnish-crest-data harnish-crest-data changed the title [O11y][Oracle] Migrate Performance dashboard visualizations to lens in kibana 8.6.0 [O11y][Oracle] Migrate Performance dashboard visualizations to lens in kibana 8.6.0 Mar 30, 2023
@kush-elastic kush-elastic added enhancement New feature or request Team:Service-Integrations Label for the Observability Service Integrations team Integration:oracle Oracle labels Mar 30, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T09:03:07.358+0000

  • Duration: 30 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 30, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚
Lines 94.318% (249/264) ❕
Conditionals 100.0% (0/0) 💚

@milan-elastic
Copy link
Contributor

Thanks, @harnish-elastic ! Looks good, Approved!

@agithomas
Copy link
Contributor

Can you continue populating the data for some more time or change the time window so that the panel has data fully filled and does not look broken. Referring to the screenshot.

@agithomas
Copy link
Contributor

Why the kibana version change to 8.6.0 ?

@kush-elastic
Copy link
Contributor

Why the kibana version change to 8.6.0 ?

We have already provided the reason behind why we are migrating to Kibana version 8.6.0 in the issue itself. The reason behind why we have mentioned there is that the dashboard (System Statistics) which lets us use kibana 8.6.0 is different from this PR.

@harnish-crest-data
Copy link
Contributor Author

Can you continue populating the data for some more time or change the time window so that the panel has data fully filled and does not look broken. Referring to the screenshot.

All the panels are populated with data and charts looks good. Are you suggesting to still update the screenshots with more data? https://raw.githubusercontent.com/elastic/integrations/f2f477af91fdc98439a67f630900ae46e21a6f2c/packages/oracle/img/Oracle-performance-dashboard.png

@agithomas
Copy link
Contributor

Can you continue populating the data for some more time or change the time window so that the panel has data fully filled and does not look broken. Referring to the screenshot.

All the panels are populated with data and charts looks good. Are you suggesting to still update the screenshots with more data? https://raw.githubusercontent.com/elastic/integrations/f2f477af91fdc98439a67f630900ae46e21a6f2c/packages/oracle/img/Oracle-performance-dashboard.png

Please ignore this comment. I observed the panel looked broken and on recheck, it looked fine.

@agithomas agithomas requested a review from a team March 31, 2023 07:52
@agithomas
Copy link
Contributor

@efd6 , are there concerns with the security team to set 8.6.0 as the min version for Oracle integration ?

@efd6
Copy link
Contributor

efd6 commented Apr 3, 2023

@agithomas If the bump is required for the visualisation changes then it's OK. This is what we have been doing recently. See #5493 (comment).

agithomas
agithomas approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-crest-data
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
13dfc89 
…into lens_migration-oracle-performance

Conflicts:
	packages/oracle/changelog.yml
	packages/oracle/manifest.yml
@kush-elastic kush-elastic merged commit e5b39cd into elastic:main Apr 13, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Nov 6, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agithomas agithomas agithomas approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harnish-crest-data harnish-crest-data

Labels

enhancement New feature or request Integration:oracle Oracle Team:Service-Integrations Label for the Observability Service Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@harnish-crest-data @elasticmachine @milan-elastic @agithomas @kush-elastic @efd6