Skip to content

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 21, 2023

What does this PR do?

  1. remove aws.dimensions.* fields from all aws metrics data streams
  2. add specific dimensions for s3_storage_lens
  3. remove duplicated aws.dimensions.* from cloudwatch_metrics

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner June 21, 2023 16:03
@elasticmachine
Copy link

elasticmachine commented Jun 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-22T12:16:35.147+0000

  • Duration: 47 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 21, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 85.714% (240/280) 👎 -14.286
Lines 85.925% (7387/8597) 👎 -6.976
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng merged commit 256e011 into elastic:main Jun 22, 2023
@elasticmachine
Copy link

Package aws - 1.45.3 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aws] add explicit mappings for aws.dimensions.* fields in metrics integrations

4 participants