Skip to content

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Dec 5, 2023

Proposed commit message

This PR adds tags, processors, and preserve_original_event to MySQL's error and slowlog datastreams.
It also updates pipelines to rename the message field to event.original and handle cases where tags contain preserve_original_event.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screenshot 2023-12-08 at 5 12 07 PM Screenshot 2023-12-08 at 5 11 56 PM

@ritalwar ritalwar added the enhancement New feature or request label Dec 5, 2023
@elasticmachine
Copy link

elasticmachine commented Dec 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-13T08:27:18.724+0000

  • Duration: 25 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 41
Skipped 0
Total 41

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ritalwar
Copy link
Contributor Author

ritalwar commented Dec 5, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Dec 6, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 15.385
Classes 100.0% (2/2) 💚 15.385
Methods 93.103% (27/29) 👍 3.273
Lines 89.474% (170/190) 👍 0.259
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

elasticmachine commented Dec 8, 2023

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ritalwar ritalwar marked this pull request as ready for review December 8, 2023 11:56
@ritalwar ritalwar requested a review from a team as a code owner December 8, 2023 11:56
@ritalwar ritalwar requested a review from muthu-mps December 8, 2023 11:56
@ritalwar ritalwar requested a review from muthu-mps December 12, 2023 06:08
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@niraj-elastic niraj-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM apart from this comment.

@mrodm
Copy link
Collaborator

mrodm commented Dec 21, 2023

Hi @ritalwar, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@niraj-elastic
Copy link
Contributor

LGTM!

@ritalwar ritalwar merged commit c25eaf4 into elastic:main Jan 2, 2024
@elasticmachine
Copy link

Package mysql - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=mysql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:mysql MySQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Mysql] Add support for tags, processors & preserve_original_event

6 participants