-
Notifications
You must be signed in to change notification settings - Fork 7.7k
Add 4D Systems' ESP32-P4 MIPI Display Modules #11819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello cruzjuniel, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDII: sorry there is a gen-4 board already.
All good. Thanks. I had moved it to the end anyway. There seems to be an error in the boards test for an option we added "Display Model" which is an optional setting to manually identify the display type. I hope it's something that can simply be ignored for this test as it seems to be checking the build.board is uppercase. |
Yes the CI error is due to unhandled change and it thinks it's a board. The real boards test are passing. |
@cruzjuniel Please fix errors in CI - Pre-commit hooks: https://github.com/espressif/arduino-esp32/actions/runs/17649063157/job/50154895596?pr=11819 |
Hi @P-R-O-C-H-Y, please let us know if there's any further changes required. Thanks. Will there be minor release updates that this board can be a part of or do we need to wait for v3.4.0? When is the target next release? Thanks |
@cruzjuniel there is another error to fix: https://github.com/espressif/arduino-esp32/actions/runs/17650696495/job/50176558135?pr=11819#step:3:16 |
Hi @me-no-dev, from the previous discussion here:
And @P-R-O-C-H-Y, confirmed it's a false error
|
@me-no-dev yes, this needs a fix in get boards script. The menu addition is taken as a board. So its a false ci error. Can be merged :) |
@cruzjuniel To aswer the Q about the release, your board addition will be available in next release 3.3.1 which will happen soon. |
Thanks! I just read here that the scheduled release for v3.3.1 is planned for the 17th. Looking forward to it! |
Description of Change
This request adds a new board variant for 4D Systems' ESP32-P4 MIPI display modules.
Test Scenarios
We have tested this pull request on Arduino-ESP32 v3.3.0
Related links
No related links to issues. Product pages are waiting for release.
Datasheets will be available at the time of release in 4D Systems' Resource Centre.