Skip to content

Conversation

cruzjuniel
Copy link
Contributor

Description of Change

This request adds a new board variant for 4D Systems' ESP32-P4 MIPI display modules.

Test Scenarios

We have tested this pull request on Arduino-ESP32 v3.3.0

Related links

No related links to issues. Product pages are waiting for release.
Datasheets will be available at the time of release in 4D Systems' Resource Centre.

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Sep 11, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello cruzjuniel, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d6268af

@lucasssvaz lucasssvaz added the Type: 3rd party Boards Related to third-party/non-Espressif hardware boards. label Sep 11, 2025
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDII: sorry there is a gen-4 board already.

@cruzjuniel
Copy link
Contributor Author

EDII: sorry there is a gen-4 board already.

All good. Thanks. I had moved it to the end anyway.

There seems to be an error in the boards test for an option we added "Display Model" which is an optional setting to manually identify the display type. I hope it's something that can simply be ignored for this test as it seems to be checking the build.board is uppercase.

@P-R-O-C-H-Y
Copy link
Member

Yes the CI error is due to unhandled change and it thinks it's a board. The real boards test are passing.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Sep 11, 2025
@P-R-O-C-H-Y
Copy link
Member

@cruzjuniel Please fix errors in CI - Pre-commit hooks: https://github.com/espressif/arduino-esp32/actions/runs/17649063157/job/50154895596?pr=11819

@cruzjuniel
Copy link
Contributor Author

@cruzjuniel Please fix errors in CI - Pre-commit hooks: https://github.com/espressif/arduino-esp32/actions/runs/17649063157/job/50154895596?pr=11819

Hi @P-R-O-C-H-Y, please let us know if there's any further changes required. Thanks.

Will there be minor release updates that this board can be a part of or do we need to wait for v3.4.0? When is the target next release? Thanks

@me-no-dev
Copy link
Member

@cruzjuniel
Copy link
Contributor Author

@cruzjuniel there is another error to fix: https://github.com/espressif/arduino-esp32/actions/runs/17650696495/job/50176558135?pr=11819#step:3:16

Hi @me-no-dev, from the previous discussion here:

There seems to be an error in the boards test for an option we added "Display Model" which is an optional setting to manually identify the display type. I hope it's something that can simply be ignored for this test as it seems to be checking the build.board is uppercase.

And @P-R-O-C-H-Y, confirmed it's a false error

Yes the CI error is due to unhandled change and it thinks it's a board. The real boards test are passing.

@P-R-O-C-H-Y
Copy link
Member

@me-no-dev yes, this needs a fix in get boards script. The menu addition is taken as a board. So its a false ci error. Can be merged :)

@me-no-dev me-no-dev merged commit d136bce into espressif:master Sep 12, 2025
14 of 15 checks passed
@P-R-O-C-H-Y
Copy link
Member

@cruzjuniel To aswer the Q about the release, your board addition will be available in next release 3.3.1 which will happen soon.

@cruzjuniel
Copy link
Contributor Author

Thanks! I just read here that the scheduled release for v3.3.1 is planned for the 17th. Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards Related to third-party/non-Espressif hardware boards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants