Skip to content

fix: ButtonComponent behavior when the engine is paused#1726

Merged
spydon merged 6 commits into
flame-engine:mainfrom
st-pasha:ps.button-component
Jun 14, 2022
Merged

fix: ButtonComponent behavior when the engine is paused#1726
spydon merged 6 commits into
flame-engine:mainfrom
st-pasha:ps.button-component

Conversation

@st-pasha
Copy link
Copy Markdown
Contributor

@st-pasha st-pasha commented Jun 13, 2022

Description

  • In Component, we will now avoid adoption queue when setting parent to the same as the current;
  • The ButtonComponent avoids swapping button and buttonDown components if buttonDown is null;

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • [-] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #1723

Comment thread packages/flame/lib/src/components/input/button_component.dart Outdated
@spydon spydon requested a review from a team June 13, 2022 20:25
@spydon spydon merged commit 197e63d into flame-engine:main Jun 14, 2022
@st-pasha st-pasha deleted the ps.button-component branch June 14, 2022 07:01
st-pasha added a commit to st-pasha/flame that referenced this pull request Jun 18, 2022
…#1726)

- In Component, we will now avoid adoption queue when setting parent to the same as the current;
- The ButtonComponent avoids swapping button and buttonDown components if buttonDown is null;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Null exception while removing overlay and resuming engine

3 participants