Skip to content

Fix Github Output On Windows#207

Merged
AndrewKahr merged 2 commits into
mainfrom
hotfix-windows-workflows
Apr 12, 2023
Merged

Fix Github Output On Windows#207
AndrewKahr merged 2 commits into
mainfrom
hotfix-windows-workflows

Conversation

@AndrewKahr
Copy link
Copy Markdown
Member

Changes

  • Fix Windows hook inputs not being passed through properly

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

@AndrewKahr AndrewKahr marked this pull request as ready for review April 12, 2023 22:42
@github-actions
Copy link
Copy Markdown

Cat Gif

@AndrewKahr AndrewKahr marked this pull request as draft April 12, 2023 23:05
@AndrewKahr AndrewKahr changed the title Fix incorrect conditional Fix Github Output On Windows Apr 12, 2023
@AndrewKahr AndrewKahr marked this pull request as ready for review April 12, 2023 23:12
Copy link
Copy Markdown
Member

@GabLeRoux GabLeRoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this change is good, I haven't checked if there are other vars which should need this change tho.

@AndrewKahr AndrewKahr merged commit f37267a into main Apr 12, 2023
@AndrewKahr AndrewKahr deleted the hotfix-windows-workflows branch April 12, 2023 23:17
@AndrewKahr
Copy link
Copy Markdown
Member Author

I searched through the repo and found no other instances on windows so we should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants