Update Dockerfile #221
Closed
Update Dockerfile #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
解决找不到mysqldump
siddontang
reviewed
Mar 18, 2018
| COPY . /go/src/github.com/siddontang/go-mysql-elasticsearch | ||
|
|
||
| RUN cd /go/src/github.com/siddontang/go-mysql-elasticsearch/ && \ | ||
| RUN apk add --no-cache mariadb-client && \ |
There was a problem hiding this comment.
can you use another RUN for apk especially?
There was a problem hiding this comment.
Yes.
I thought the mysqldump is required by go-mysql-elasticsearch, so made them into one layer.
There was a problem hiding this comment.
Mostly, installing pkg should be separated from others. It is cache friendly for docker.
|
Rest LGTM |
|
already included, close now. Thanks @honst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
解决找不到mysqldump