fix table change (#136 #217) #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddontang
reviewed
Apr 4, 2018
| func (r *River) updateRule(schema, table string) error { | ||
| rule, ok := r.rules[ruleKey(schema, table)] | ||
| if !ok { | ||
| return ErrRuleNotExist |
There was a problem hiding this comment.
seem no need to care No Rule error.
There was a problem hiding this comment.
yes, it's unnecessary now, but I think that update something should return error when entity not found. so I add this.
|
I compare both PRs and find that this can pass Go lint, so I will merge this if possible. |
|
can you add a test for this? |
siddontang
reviewed
Apr 4, 2018
river/river_test.go
Outdated
| testWaitSyncDone(c, s.r) | ||
|
|
||
| r = s.testElasticGet(c, "1000") | ||
| c.Assert(r.Found, Equals, true) |
There was a problem hiding this comment.
use IsTrue instead of Equals true
siddontang
reviewed
Apr 4, 2018
river/river_test.go
Outdated
| r = s.testElasticGet(c, "1001") | ||
| c.Assert(r.Found, Equals, true) | ||
| _, ok := r.Source["new"] | ||
| c.Assert(ok, Equals, false) |
|
I can only add test cases for "ALTER TABLE". make no sense:
cause error and make program exit:
and we can't alter table when program is running mysqldump. because length of table columns will not match with length of data. |
|
thanks @yaoguais This doesn't cover all cases, we should improve DDL one by one. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.