add support for geo_point and boolean #316
Conversation
|
Thanks @Leihb Sorry for the late response, I will review it this week. |
| fieldTypeGeopointLat = "geo_point.lat" | ||
| fieldTypeGeopointLon = "geo_point.lon" | ||
|
|
||
| fieldTypeBoolean = "bool" |
There was a problem hiding this comment.
is this type associated with geo type?
If not, I suggest using another PR to support it.
| if mysql == c.Name { | ||
| mapped = true | ||
| req.Data[elastic] = r.getFieldValue(&c, fieldType, values[i]) | ||
| if fieldType == fieldTypeGeopointLat { |
There was a problem hiding this comment.
why not handing this in getFieldValue?
There was a problem hiding this comment.
because getFieldValue has no access to already read field values and would overwrite the first part of the geo point.
for long and lat it would do:
- getFieldValue for longitude. returns map with { long: n }
- getFieldValue for latitude. return map with { lat: n }
- writing data would require to merge the both results, because we can't access the already processed data (or next)
|
@Leihb I tried out your changes and it looks like your changes don't work. EDIT: had it linked wrong. works like it should, thanks @Leihb |
use
is_active = "is_active,bool"to map a mysql tinyint to es boolean,use
lat = "location,geo_point.lat" lon = "location,geo_point.lon"to create a es geo_point