Small adjustments to the new record code.#2219
Merged
Merged
Conversation
* Replace wildcard imports with single imports. * Enable `Java17RecordTest` and fix its many previously-hidden problems. * Use a `Map` to get primitive zero values rather than a potentially-expensive reflective trick. * Apply some automated code fixes.
Member
Author
|
@staale FYI, very minor things. |
Marcono1234
approved these changes
Oct 11, 2022
Contributor
Marcono1234
left a comment
There was a problem hiding this comment.
Looks good! Only some minor suggestions for improvements, but if you want I can address them in a separate pull request as well.
Marcono1234
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Java17RecordTestand fix its many previously-hidden problems.Mapto get primitive zero values rather than a potentially-expensive reflective trick.