Skip to content

AutoML: Remove GcsClient from automl_v1beta1?? (via synth) #9179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2019
Merged

AutoML: Remove GcsClient from automl_v1beta1?? (via synth) #9179

merged 2 commits into from
Sep 16, 2019

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/automl/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:0e6f3a668cd68afc768ecbe08817cf6e56a0e64fcbdb1c58c3b97492d12418a1
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/automl/artman_automl_v1beta1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/text_extraction.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/text_extraction.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/io.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/io.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/classification.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/classification.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/operations.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/operations.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/tables.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/tables.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/data_stats.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/data_stats.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/ranges.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/ranges.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/column_spec.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/column_spec.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/detection.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/detection.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/dataset.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/dataset.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/model.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/model.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/data_items.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/data_items.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/annotation_payload.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/annotation_payload.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/temporal.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/temporal.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/text_sentiment.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/text_sentiment.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/annotation_spec.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/annotation_spec.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/model_evaluation.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/model_evaluation.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/translation.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/translation.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/image.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/image.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/prediction_service.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/prediction_service.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/table_spec.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/table_spec.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/text.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/text.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/regression.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/regression.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/data_types.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/data_types.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/geometry.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/geometry.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/text_segment.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/text_segment.proto
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/cloud/automl/v1beta1/video.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto/video.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/automl-v1beta1/google/cloud/automl_v1beta1/proto.
synthtool > Replaced 'from google.cloud.automl_v1beta1.gapic import prediction_service_client' in google/cloud/automl_v1beta1/__init__.py.
synthtool > Replaced "__all__ = \\(\n    'enums',\n    'types',\n    'AutoMlClient',\n    'PredictionServiceClient',\n\\)" in google/cloud/automl_v1beta1/__init__.py.
synthtool > Replaced 'metadata_type=operations_pb2.OperationMetadata' in google/cloud/automl_v1beta1/gapic/auto_ml_client.py.
synthtool > No replacements made in google/cloud/automl_v1beta1/gapic/prediction_service_client.py for pattern ^\s+::, maybe replacement is not longer needed?
synthtool > No replacements made in google/cloud/automl_v1beta1/gapic/auto_ml_client.py for pattern ^(\s+)(::)

\s+?([^\s]), maybe replacement is not longer needed?
synthtool > Replaced 'Sample in-line\n     JSON Lines file.*?\\}`\\n' in google/cloud/automl_v1beta1/proto/io_pb2.py.
synthtool > Replaced 'Sample\n     in-line JSON Lines.*?(\\n\\s+-\\s+For Text Classification.*\\n)' in google/cloud/automl_v1beta1/proto/io_pb2.py.
synthtool > Replaced '__doc__ = \\"\\"\\"-  For Translation: CSV file ``translation\\.csv``, with each ' in google/cloud/automl_v1beta1/proto/io_pb2.py.
synthtool > Replaced ':raw-latex:`\\\\t `' in google/cloud/automl_v1beta1/proto/io_pb2.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black==19.3b0
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/enums.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/docs/conf.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/prediction_service_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/auto_ml_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/transports/prediction_service_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/transports/auto_ml_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/annotation_payload_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/prediction_service_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/annotation_spec_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/annotation_spec_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/classification_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/annotation_payload_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/column_spec_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/column_spec_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_items_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/classification_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_stats_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/gapic/auto_ml_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_types_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_items_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/dataset_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_types_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/detection_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/geometry_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/geometry_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/dataset_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/image_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/data_stats_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/io_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_evaluation_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/detection_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/image_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_evaluation_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/operations_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/model_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/prediction_service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/io_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/ranges_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/ranges_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/regression_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/regression_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/prediction_service_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/operations_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/table_spec_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/table_spec_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/tables_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/temporal_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/temporal_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/service_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_extraction_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_extraction_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_segment_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_segment_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_sentiment_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/tables_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/translation_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/video_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/video_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/translation_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/text_sentiment_pb2.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/types.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/noxfile.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/tests/unit/gapic/v1beta1/test_prediction_service_client_v1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/tests/unit/gapic/v1beta1/test_auto_ml_client_v1beta1.py
reformatted /tmpfs/src/git/autosynth/working_repo/automl/google/cloud/automl_v1beta1/proto/service_pb2.py
All done! ✨ 🍰 ✨
70 files reformatted, 12 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 2 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: automl Issues related to the AutoML API. label Sep 5, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 5, 2019
@tseaver tseaver added the codegen label Sep 5, 2019
@tseaver tseaver changed the title [CHANGE ME] Re-generated automl to pick up changes in the API or client library generator. AutoML: Remove GcsClient from automl_v1beta1?? Sep 5, 2019
tseaver
tseaver reviewed Sep 5, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@busunkim96 I'm dubious about this change: the GAPIC-generated code for gcs_client.py remains, as do the tests. Also, the tests for other modules rely on pands, which means removing those extras in noxfile..py is questionable.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 5, 2019
@tseaver tseaver changed the title AutoML: Remove GcsClient from automl_v1beta1?? AutoML: Remove GcsClient from automl_v1beta1?? (via synth) Sep 5, 2019
@busunkim96
Copy link
Contributor

@tseaver Yep, I'll need to add a synth replace to add GcsClient so Autosynth doesn't try to remove it. 😅 Will keep this open for now.

@busunkim96 busunkim96 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 13, 2019
@tseaver tseaver merged commit b32ba26 into master Sep 16, 2019
@tseaver tseaver deleted the autosynth-automl branch September 16, 2019 15:16
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@yoshi-automation @emar-kar
Preserve GcsClient, 'pandas' extras in testing (via synth). (googleap…
99303a9 
…is#9179)
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@yoshi-automation @emar-kar
Preserve GcsClient, 'pandas' extras in testing (via synth). (googleap…
596b40d 
…is#9179)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@yoshi-automation @tseaver
Preserve GcsClient, 'pandas' extras in testing (via synth). (#9179)
d99b4b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: automl Issues related to the AutoML API. cla: yes This human has signed the Contributor License Agreement. codegen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yoshi-automation @busunkim96 @tseaver @googlebot