Skip to content

Conversation

crwilcox
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 28, 2019
self.API_BASE_URL = api_endpoint
self._client_info.client_library_version = __version__

# TODO: When metrics all use gccl, this should be removed b/143493862
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we link to public issue tracker instead to align internal and external comms?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure :)

Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@crwilcox crwilcox force-pushed the storage-gcloud-python-agent branch from 3be879a to d3b3a6e Compare October 29, 2019 04:30
@crwilcox crwilcox merged commit 025867a into master Oct 29, 2019
@crwilcox crwilcox deleted the storage-gcloud-python-agent branch October 29, 2019 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants