deps: declare google-auth-library-oauth2-http #879
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hannahrogers-google @Neenu1995 I think this will fix the potential missing |
|
The build is failing. It's used here Why? How to reproduce?The following command fails: |
The Maven analyzer plugin somehow marks the auth library unused even though it's actually used. googleapis#879
suztomo
commented
Oct 18, 2021
| <ignoredUnusedDeclaredDependencies> | ||
| <ignoredUnusedDeclaredDependency>io.opencensus:opencensus-impl</ignoredUnusedDeclaredDependency> | ||
| <ignoredUnusedDeclaredDependency>javax.annotation:javax.annotation-api</ignoredUnusedDeclaredDependency> | ||
| <ignoredUnusedDeclaredDependency>com.google.auth:google-auth-library-oauth2-http</ignoredUnusedDeclaredDependency> |
There was a problem hiding this comment.
Somehow I have to mark this artifact in ignoredUnusedDeclaredDependency even though it's actually used.
There was a problem hiding this comment.
I think we won't need to add an exception when compilation becomes really broken after the new release of the shared dependencies BOM.
suztomo
commented
Oct 18, 2021
Comment on lines
+44
to
+47
| <dependency> | ||
| <groupId>com.google.auth</groupId> | ||
| <artifactId>google-auth-library-oauth2-http</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Why would this fail the "ci / dependencies"?
|
#882 has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️