samples: adds LCI samples #1251
Conversation
Due to master merge the compilation was failing. Fixes the builder construction here.
Adds default implementation for the InstanceInfo set processing units in order to avoid a breaking change.
Removes the LCI samples for now, because they won't compile. We will re-add them once the main implementation is released.
This reverts commit dc17892.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the βΉοΈ Googlers: Go here for more info. |
| // Set Instance configuration. | ||
| String configId = "regional-us-central1"; | ||
| // This will create an instance with the processing power of 0.2 nodes. | ||
| int processingUnits = 200; |
There was a problem hiding this comment.
@thiagotnunes From the spec, I think this value should be 500.
β¦essing-units-samples
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the βΉοΈ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the βΉοΈ Googlers: Go here for more info. |
Only merge this once a release has been made from the main library and the samples dependency has been updated.