Skip to content

WIP: Attempt at reproducing "refCount dropped below zero" #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

WIP: Attempt at reproducing "refCount dropped below zero" #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,11 +997,11 @@ protected PartialResultSet computeNext() {
continue;
}
span.addAnnotation("Stream broken. Not safe to retry");
TraceUtil.endSpanWithFailure(span, e);
//TraceUtil.endSpanWithFailure(span, e);
throw e;
} catch (RuntimeException e) {
span.addAnnotation("Stream broken. Not safe to retry");
TraceUtil.endSpanWithFailure(span, e);
//TraceUtil.endSpanWithFailure(span, e);
throw e;
}
}
Expand Down
22 changes: 22 additions & 0 deletions google-cloud-spanner/src/test/java/com/google/cloud/spanner/ResumableStreamIteratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,28 @@ public void nonRetryableError() {
assertThat(strings.next()).isNotEqualTo("X");
}

@Test
public void closedSpanOnNonRetryableError() {
Span span = mock(Span.class);
Whitebox.setInternalState(this.resumableStreamIterator, "span", span);

ResultSetStream s1 = Mockito.mock(ResultSetStream.class);
Mockito.when(starter.startStream(null)).thenReturn(new ResultSetIterator(s1));
Mockito.when(s1.next())
.thenReturn(resultSet(ByteString.copyFromUtf8("r1"), "a"))
.thenReturn(resultSet(ByteString.copyFromUtf8("r2"), "b"))
.thenReturn(resultSet(null, "X"))
.thenReturn(resultSet(null, "X"))
.thenThrow(new NonRetryableException(ErrorCode.FAILED_PRECONDITION, "failed by test"));
Iterator<String> strings = stringIterator(resumableStreamIterator);
assertThat(strings.next()).isEqualTo("a");
assertThat(strings.next()).isEqualTo("b");
expectedException.expect(isSpannerException(ErrorCode.FAILED_PRECONDITION));
assertThat(strings.next()).isNotEqualTo("X");

verify(span).end(EndSpanOptions.builder().setSampleToLocalSpanStore(true).build());
}

@Test
public void bufferLimitSimple() {
initWithLimit(1);
Expand Down