Skip to content

fix: replaced raise NotImplementedError with return NotImplemented #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 12, 2023
Merged

fix: replaced raise NotImplementedError with return NotImplemented #258

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d3cc427
Replaced `NotImplementedError` with `NotImplemented`
nydelzaf Dec 5, 2023
cfbd092
Merge branch 'main' into Fix_Improper_Method_Call_NotImplemented
tswast Dec 8, 2023
3802ff8
Merge branch 'main' into Fix_Improper_Method_Call_NotImplemented
tswast Dec 8, 2023
a7712e4
Merge branch 'main' into Fix_Improper_Method_Call_NotImplemented
tswast Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions third_party/bigframes_vendored/pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,13 +677,13 @@ def __matmul__(self, other):
"""
Matrix multiplication using binary `@` operator in Python>=3.5.
"""
raise NotImplementedError(constants.ABSTRACT_METHOD_ERROR_MESSAGE)
return NotImplemented

def __rmatmul__(self, other):
"""
Matrix multiplication using binary `@` operator in Python>=3.5.
"""
raise NotImplementedError(constants.ABSTRACT_METHOD_ERROR_MESSAGE)
return NotImplemented

def sort_values(
self,
Expand Down