Skip to content

chore: emit a warning if return_immediately flag is set with synchronous pull #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

chore: emit a warning if return_immediately flag is set with synchronous pull #355

merged 1 commit into from
Mar 31, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Mar 31, 2021

Closes #350.

This PR patches the generated client to emit a DeprecationWarning if return_immediately flag is set.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut
chore: emit a warning if return_immediately is set
9e34579 
This flag is deprecated and should always be set to `False` when
pulling messages synchronously.
@plamut plamut requested a review from a team as a code owner March 31, 2021 12:07
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 31, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2021
@plamut plamut merged commit 20f0712 into googleapis:master Mar 31, 2021
@plamut plamut deleted the iss-350 branch March 31, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate 'return_immediately' argument
2 participants
@plamut @anguillanneuf