Skip to content

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Jun 23, 2021

Address @kamalaboulhosn 's comments in #717

The goal of the sample pubsub_publish_with_error_handler is to show how to handle publish failures. In the current iteration, I want to show how to catch and handle TimeoutError. I know using a generic exception isn't generally recommended by samples rubrics. Let me know if you see a better type of error to catch in this sample.

@anguillanneuf anguillanneuf requested a review from a team as a code owner June 23, 2021 15:25
@anguillanneuf anguillanneuf requested review from leahecole and removed request for a team June 23, 2021 15:25
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Jun 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2021
@anguillanneuf anguillanneuf merged commit 2446818 into master Jun 23, 2021
@anguillanneuf anguillanneuf deleted the publish-flow-comment branch June 23, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants