Skip to content

feat: increase GRPC max metadata size to 4 MB #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2022
Merged

feat: increase GRPC max metadata size to 4 MB #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2895ff3
Increase GRPC max metadata size to 4 MB
pradn Mar 22, 2022
11e8122
run owlbot-cli copy code; run owlbot post processor
parthea Mar 22, 2022
25bad91
Merge branch 'main' into eos-increase-grpc-metadata-limit
pradn Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions google/pubsub_v1/services/publisher/transports/grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def __init__(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down
1 change: 1 addition & 0 deletions google/pubsub_v1/services/publisher/transports/grpc_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ def __init__(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down
1 change: 1 addition & 0 deletions google/pubsub_v1/services/schema_service/transports/grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ def __init__(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down
1 change: 1 addition & 0 deletions google/pubsub_v1/services/schema_service/transports/grpc_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ def __init__(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down
1 change: 1 addition & 0 deletions google/pubsub_v1/services/subscriber/transports/grpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ def __init__(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down
1 change: 1 addition & 0 deletions google/pubsub_v1/services/subscriber/transports/grpc_asyncio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ def __init__(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down
1 change: 1 addition & 0 deletions owlbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
"""options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
]""",
flags=re.MULTILINE | re.DOTALL,
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/gapic/pubsub_v1/test_publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,7 @@ def test_publisher_client_create_channel_credentials_file(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -2909,6 +2910,7 @@ def test_publisher_transport_create_channel(transport_class, grpc_helpers):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -2939,6 +2941,7 @@ def test_publisher_grpc_transport_client_cert_source_for_mtls(transport_class):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -3044,6 +3047,7 @@ def test_publisher_transport_channel_mtls_with_client_cert_source(transport_clas
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -3089,6 +3093,7 @@ def test_publisher_transport_channel_mtls_with_adc(transport_class):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/gapic/pubsub_v1/test_schema_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,7 @@ def test_schema_service_client_create_channel_credentials_file(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -2175,6 +2176,7 @@ def test_schema_service_transport_create_channel(transport_class, grpc_helpers):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -2208,6 +2210,7 @@ def test_schema_service_grpc_transport_client_cert_source_for_mtls(transport_cla
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -2316,6 +2319,7 @@ def test_schema_service_transport_channel_mtls_with_client_cert_source(transport
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -2364,6 +2368,7 @@ def test_schema_service_transport_channel_mtls_with_adc(transport_class):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/gapic/pubsub_v1/test_subscriber.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,7 @@ def test_subscriber_client_create_channel_credentials_file(
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -4204,6 +4205,7 @@ def test_subscriber_transport_create_channel(transport_class, grpc_helpers):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -4234,6 +4236,7 @@ def test_subscriber_grpc_transport_client_cert_source_for_mtls(transport_class):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -4339,6 +4342,7 @@ def test_subscriber_transport_channel_mtls_with_client_cert_source(transport_cla
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down Expand Up @@ -4384,6 +4388,7 @@ def test_subscriber_transport_channel_mtls_with_adc(transport_class):
options=[
("grpc.max_send_message_length", -1),
("grpc.max_receive_message_length", -1),
("grpc.max_metadata_size", 4 * 1024 * 1024),
("grpc.keepalive_time_ms", 30000),
],
)
Expand Down