fix: update user_project usage and documentation in bucket/client class methods #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsg
requested changes
Mar 23, 2021
cojenco
added a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…ss methods (googleapis#396) * fix: update documentation and usage of user_project in bucket class methods * revise Bucket.create() docstring * revise Bucket @Property user_project docstring * add example to client.get_bucket() with user_project * revise deprecated Bucket.create() and unit test * fix lint * address review changes
cojenco
added a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…ss methods (googleapis#396) * fix: update documentation and usage of user_project in bucket class methods * revise Bucket.create() docstring * revise Bucket @Property user_project docstring * add example to client.get_bucket() with user_project * revise deprecated Bucket.create() and unit test * fix lint * address review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter user_project is the project to be billed for the request; It is required for requests to buckets that have Requester Pays enabled. This PR includes changes with the aim of enhancing consistency and clarity to user_project usage:
Fixes #148