Skip to content

feat: generate signed URLs for blobs/buckets using virtual hostname #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 13, 2020
Merged

feat: generate signed URLs for blobs/buckets using virtual hostname #58

merged 4 commits into from
Feb 13, 2020

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 13, 2020

Closes #10.

@tseaver tseaver requested review from crwilcox and frankyn February 13, 2020 01:37
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020
frankyn
frankyn suggested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit.

google/cloud/storage/blob.py Outdated
version=None,
service_account_email=None,
access_token=None,
use_virtual_hostname=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use virtual_hosted_style instead.

@tseaver tseaver force-pushed the 10-v4-signing-virtual-hostname branch from 5e949f2 to 3be7f6e Compare February 13, 2020 17:09
@tseaver tseaver force-pushed the 10-v4-signing-virtual-hostname branch from 3be7f6e to b75fd1d Compare February 13, 2020 19:39
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 13, 2020
frankyn
frankyn approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tseaver tseaver merged commit 23df542 into master Feb 13, 2020
@tseaver tseaver deleted the 10-v4-signing-virtual-hostname branch February 13, 2020 20:32
@yoshi-automation yoshi-automation mentioned this pull request Feb 19, 2020
Merged
@frankyn frankyn mentioned this pull request Mar 11, 2020
Merged
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
feat: generate signed URLs for blobs/buckets using virtual hostname (g…
132e284 
…oogleapis#58)

* Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url'
* Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@tseaver @cojenco
feat: generate signed URLs for blobs/buckets using virtual hostname (g…
6caf854 
…oogleapis#58)

* Add 'virtual_hosted_style' arg to 'Blob.generate_signed_url'
* Add 'virtual_hosted_style arg to 'Bucket.generate_signed_url'
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@frankyn frankyn frankyn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Storage] V4 Signature Support for virtual hosted-style signed
4 participants
@tseaver @frankyn @googlebot @yoshi-kokoro