Skip to content

Specified parameters when getting SetApplicationIdentifier #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Specified parameters when getting SetApplicationIdentifier #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Specified parameters when getting SetApplicationIdentifier to resolve… 
… AmbiguousMatchException

fix Unity compatibility issue https://issuetracker.unity3d.com/issues/firebase-importing-package-and-restarting-the-editor-generates-ambiguous-match-found-exceptions
  • Loading branch information
@BorysSaltan
BorysSaltan authored May 18, 2022
commit 3c6522da4da3a4619c8525a4864dd1fac48839b0
2 changes: 1 addition & 1 deletion source/AndroidResolver/src/UnityCompat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ private static string GetUnity56AndAboveApplicationIdentifier(BuildTarget buildT
private static bool SetUnity56AndAboveApplicationIdentifier(BuildTarget buildTarget,
string applicationIdentifier) {
var setApplicationIdentifierMethod =
typeof(UnityEditor.PlayerSettings).GetMethod("SetApplicationIdentifier");
typeof(UnityEditor.PlayerSettings).GetMethod("SetApplicationIdentifier", new[] {typeof(BuildTargetGroup), typeof(string) });
if (setApplicationIdentifierMethod == null) return false;
var buildTargetGroup = ConvertBuildTargetToBuildTargetGroup(buildTarget);
if (buildTargetGroup == BuildTargetGroup.Unknown) return false;
Expand Down