Skip to content

Add listener for errors that occur in parsing InvocationInput #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 21, 2022
Merged

Add listener for errors that occur in parsing InvocationInput #439

merged 7 commits into from
Jul 21, 2022

Conversation

heowc
Copy link
Contributor

@heowc heowc commented May 2, 2022

As described in #417, we cannot handle the error when creating anInvocationInput with a servlet request.

  • Change ListenerHandler creation location.
  • Add InvocationInputParseException to isolate exception to parsing.
  • Add onParseError(...) to RequestCallback interface and call it when InvocationInputParseException occurs.
  • Fix related tests.

Closes #417

@heowc heowc mentioned this pull request May 3, 2022
Closed
@heowc
Copy link
Contributor Author

heowc commented May 9, 2022

gentle ping :)

@setchy @oliemansm @vojtapol

oliemansm
oliemansm requested changes May 25, 2022
View reviewed changes
Copy link
Member

@oliemansm oliemansm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@heowc
Copy link
Contributor Author

heowc commented May 25, 2022

It seems that the jdk installation failed. 😅

https://github.com/graphql-java-kickstart/graphql-java-servlet/runs/6587368258?check_suite_focus=true

@oliemansm oliemansm merged commit ea2dec6 into graphql-java-kickstart:master Jul 21, 2022
@oliemansm oliemansm added this to the 13.0.0 milestone Aug 6, 2022
@internetstaff internetstaff mentioned this pull request Jul 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliemansm oliemansm oliemansm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
13.0.0
Development

Successfully merging this pull request may close these issues.

Cannot error handle on creating GraphqlInvocationInput
2 participants
@heowc @oliemansm