Add test for foreign libs to depend on Haskell libs #4065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, this PR got swizzled by the package-tests move. Just transplant the changes into the new cabal-testsuite directory, or tell me if you want me to do it. |
|
Lovely, nice new test which uncovers some bugs in the foreign library implementation.
|
Also bump version requirements for foreign libs (ghc>=7.8)
|
I made the modifications that you proposed: rebased, ran |
|
Pinging @edsko: If you need foreign libraries to work on pre GHC 7.8, you better check this bug out! |
|
No, pre 7.8 support for limited anyway (#2540 (comment)). Fine with me to just regard as unsupported. |
abooij
added a commit
to abooij/cabal
that referenced
this pull request
Nov 1, 2016
Duplication introduced by haskell#4065.
erikd
pushed a commit
to erikd/cabal
that referenced
this pull request
Jan 28, 2017
Also bump version requirements for foreign libs (ghc>=7.8)
erikd
pushed a commit
to erikd/cabal
that referenced
this pull request
Jan 28, 2017
Duplication introduced by haskell#4065.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to test if a foreign library can depend on Haskell code in the same project but in a different binary object.