HHH-19852 Replace exception-based MAX_STRING_SIZE detection with direct query #11103
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
mbellade
reviewed
Oct 13, 2025
hibernate-core/src/main/java/org/hibernate/dialect/OracleServerConfiguration.java
Outdated
Show resolved
Hide resolved
37ba8ec to
97595c4
Compare
…ct query Query database_properties view directly instead of attempting a varchar2(32000) cast to determine if MAX_STRING_SIZE is EXTENDED. HHH-19852 fix condition HHH-19852 fix fomatting problem
97595c4 to
223e55e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the detection of Oracle's
MAX_STRING_SIZEconfiguration by querying thedatabase_propertiessystem view directly instead of relying on exception-based control flow.Changes
varchar2(32000)cast attempt with a direct query:SELECT property_value FROM database_properties WHERE property_name = 'MAX_STRING_SIZE'Related Issue
Fixes HHH-19852
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19852