exporter: print src loc for all warnings, including in type encoding#1416
Merged
Conversation
fw-immunant
approved these changes
Oct 21, 2025
Contributor
fw-immunant
left a comment
There was a problem hiding this comment.
Code changes look fine, but I don't fully understand the motivation. Is this a pure refactor, or fixing some particular place where our output was useless/incorrect before?
kkysen
commented
Oct 21, 2025
Contributor
Author
kkysen
left a comment
There was a problem hiding this comment.
Is this a pure refactor, or fixing some particular place where our output was useless/incorrect before?
I was getting errors, like the "Encountered unsupported BuiltinType kind" one, where there was no source location. clang::FullSourceLoc() was being used, but that's an invalid location. So this threads through the right source location for that and any other errors that occur in the TypeEncoder.
5a94e30 to
6c0107d
Compare
…intError`s into a top-level `getDiagBuilder` and `printDiag`
…QualTypeOf` to use in warnings
6c0107d to
68b50af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.