Skip to content

[κ³Όμ œλ²ˆμ—­] Part1 5.2 μˆ«μžν˜• 8번 과제 λ²ˆμ—­ #1509 #1582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[κ³Όμ œλ²ˆμ—­] Part1 5.2 μˆ«μžν˜• 8번 과제 λ²ˆμ—­ #1509 #1582

wants to merge 1 commit into from

Conversation

ggff23r2f2fffsdfds
Copy link
Contributor

@ggff23r2f2fffsdfds ggff23r2f2fffsdfds commented Sep 21, 2022 β€’
edited
Loading

μš”μ•½

링크 : Part1 5.2 μˆ«μžν˜•
Part1 5.2 μˆ«μžν˜•μ˜ 과제 8번 문제, 해닡을 λ²ˆμ—­ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

문제
스크란샷 2022-09-21 17 37 14

ν•΄λ‹΅
스크란샷 2022-09-21 17 35 49

μ—°κ΄€ 이슈

#1509

Pull Request 체크리슀트

TODO

  • λ²ˆμ—­ κ·œμΉ™μ„ ν™•μΈν•˜μ…¨λ‚˜μš”?
    • 쀄 λ°”κΏˆκ³Ό 단락을 '원문과 λ™μΌν•˜κ²Œ' μœ μ§€ν•˜μ…¨λ‚˜μš”?
    • λ§žμΆ€λ²• κ²€μ‚¬κΈ°λ‘œ λ§žμΆ€λ²•μ„ ν™•μΈν•˜μ…¨λ‚˜μš”?
    • λ§ˆν¬λ‹€μš΄ 문법에 μ‚¬μš©λ˜λŠ” 곡백(슀페이슀), ν°λ”°μ˜΄ν‘œ("), μž‘μ€λ”°μ˜΄ν‘œ('), λŒ€μ‹œ(-), λ°±ν‹±(`) λ“±μ˜ νŠΉμˆ˜λ¬ΈμžλŠ” κ·ΈλŒ€λ‘œ λ‘μ…¨λ‚˜μš”?
  • 둜컬 μ„œλ²„ μ„ΈνŒ… ν›„ μ΅œμ’… 결과물을 확인해 λ³΄μ…¨λ‚˜μš”?
  • PR ν•˜λ‚˜μ—” λ²ˆμ—­λ¬Έ ν•˜λ‚˜λ§Œ λ„£μœΌμ…¨λ‚˜μš”?
  • 의미 μžˆλŠ” 컀밋 λ©”μ‹œμ§€λ₯Ό μž‘μ„±ν•˜μ…¨λ‚˜μš”?
    • μ˜ˆμ‹œ
      • [ν”„λ½μ‹œ] λ²ˆμ—­
      • [ν”„λ½μ‹œ] 과제 λ²ˆμ—­
      • [ifλ¬Έκ³Ό 쑰건뢀 μ—°μ‚°μž '?'] 리뷰
      • [주석] 2μ°¨ 리뷰
      • [Date 객체와 λ‚ μ§œ] λ²ˆμ—­

@javascript-translate-bot javascript-translate-bot requested a review from a team September 21, 2022 08:37
@ggff23r2f2fffsdfds ggff23r2f2fffsdfds changed the title [κ³Όμ œλ²ˆμ—­] Part1 5.2 μˆ«μžν˜• 8-random-min-max [κ³Όμ œλ²ˆμ—­] Part1 5.2 μˆ«μžν˜• 8번 과제 λ²ˆμ—­ #1509 Sep 21, 2022
Violet-Bora-Lee
Violet-Bora-Lee requested changes Dec 7, 2022
View reviewed changes
1-js/05-data-types/02-number/8-random-min-max/solution.md Outdated

That can be done in two stages:
λ‹€μŒ λ‹¨κ³„λ‘œ μˆ˜ν–‰ν•  수 μžˆμŠ΅λ‹ˆλ‹€:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ν•œκ΅­μ–΄μ—μ„  주술 ꡬ쑰가 μžˆλŠ” λ¬Έμž₯은 온점으둜 λλ‚©λ‹ˆλ‹€. 이 λΆ€λΆ„λ§Œ μˆ˜μ •ν•΄μ£Όμ‹œλ©΄ λ°”λ‘œ 머지 μ§„ν–‰ν•˜κ² μŠ΅λ‹ˆλ‹€.
  • That λ²ˆμ—­μ΄ λˆ„λ½λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€.
Suggested change
λ‹€μŒ λ‹¨κ³„λ‘œ μˆ˜ν–‰ν•  수 μžˆμŠ΅λ‹ˆλ‹€:
맀핑은 두 λ‹¨κ³„λ‘œ μˆ˜ν–‰ν•  수 μžˆμŠ΅λ‹ˆλ‹€.

Copy link
Contributor Author

@ggff23r2f2fffsdfds ggff23r2f2fffsdfds Dec 11, 2022 β€’
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
리뷰 κ°μ‚¬ν•©λ‹ˆλ‹€!

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review πŸ‘»

@ggff23r2f2fffsdfds
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team December 11, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Violet-Bora-Lee Violet-Bora-Lee Violet-Bora-Lee requested changes

Assignees
No one assigned
Labels
review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggff23r2f2fffsdfds @javascript-translate-bot @Violet-Bora-Lee